geekhack

Site Announcements and Feedback => Announcements/Feedback/Suggestions => Topic started by: rknize on Tue, 30 April 2013, 14:21:57

Title: Introducing "More" (a.k.a. spoilers)
Post by: rknize on Tue, 30 April 2013, 14:21:57
Update: the tag for this it now "more" and the icon in the editor has been updated.

I've implemented a simple roll-up mechanism that works a lot like "spoilers" on vB, phpBB, and other forums.  We already have spoilers, so I called it something else...something a little more intuitive.  You should see a new button in the toolbar:

[attachimg=3]

You use it like any other tag and it should be able to wrap any page content, including images and attachments:
Code: [Select]
[more]Can't see me![/more]

More
Can't see me!


An offsite image:
More
(http://www.knizefamily.net/images/pool/keyboard-phantom1-angle.jpg)


An inline, expandable attachment:
More
[attach=2]


Bugs:
Title: Re: Introducing "Folds" (a.k.a. spoilers)
Post by: CPTBadAss on Tue, 30 April 2013, 14:23:58
This is awesome. You're the man! I've been wanting spoilers since I started coming to GH. They're very handy to have and can clean up a lot of posts. :D
Title: Re: Introducing "Folds" (a.k.a. spoilers)
Post by: esoomenona on Tue, 30 April 2013, 14:24:44
Quote from: rknize on Tue, 30 April 2013, 14:21:57
More
I've implemented a simple page folding mechanism that works a lot like "spoilers" on vB and other forums.  We already have spoilers, so I called it something else...something a little more intuative.  You should see a new button in the toolbar:

(Attachment Link)

You use it like any other tag and it should be able to wrap any page content, including images and attachments:
Code: [Select]
[fold]Can't see me![/fold]
More
Can't see me!


An offsite image:
More
Show Image
(http://www.knizefamily.net/images/pool/keyboard-phantom1-angle.jpg)


An inline, expandable attachment:
More
(Attachment Link)
Test

edit: super awesome. They even nest inside of each other!
Title: Re: Introducing "Folds" (a.k.a. spoilers)
Post by: Photekq on Tue, 30 April 2013, 14:25:04
Yeah, glad to see this here. It does come in useful.
Title: Re: Introducing "Folds" (a.k.a. spoilers)
Post by: ITzNybble on Tue, 30 April 2013, 14:26:28
Wonderful!
Title: Re: Introducing "Folds" (a.k.a. spoilers)
Post by: i3oilermaker on Tue, 30 April 2013, 14:26:31
Folding at Home
More
[attachimg=1]
Title: Re: Introducing "Folds" (a.k.a. spoilers)
Post by: rknize on Tue, 30 April 2013, 14:27:25
LOL....LMK what bugs you find...my jQuery is pretty rusty.
Title: Re: Introducing "Folds" (a.k.a. spoilers)
Post by: esoomenona on Tue, 30 April 2013, 14:29:52
I tried to test it with my signature, hoping when it unfolded, it would open the whole thing, but alas, it only opened the 100px (which still doesn't scroll...).
Title: Re: Introducing "Folds" (a.k.a. spoilers)
Post by: rknize on Tue, 30 April 2013, 14:31:16
Yep, I'll look at that next.
Title: Re: Introducing "Folds" (a.k.a. spoilers)
Post by: hashbaz on Tue, 30 April 2013, 14:31:52
You're awesome.
More
(http://25.media.tumblr.com/tumblr_m6h8h6439G1rwcc6bo1_400.gif) (http://25.media.tumblr.com/tumblr_m6h8h6439G1rwcc6bo1_400.gif)
Title: Re: Introducing "Folds" (a.k.a. spoilers)
Post by: Binge on Tue, 30 April 2013, 14:40:28
this is brilliant.... Binge Approves
Title: Re: Introducing "Folds" (a.k.a. spoilers)
Post by: lazerpointer on Tue, 30 April 2013, 14:40:39
Should make it change to "REFOLD" once unfolded.

Just a friendly suggestion, assuming it's even possible.

Edit;
nice tool btw
Title: Re: Introducing "Folds" (a.k.a. spoilers)
Post by: rknize on Tue, 30 April 2013, 14:49:01
Quote from: Flip on Tue, 30 April 2013, 14:40:39
Should make it change to "REFOLD" once unfolded.

Just a friendly suggestion, assuming it's even possible.

Edit;
nice tool btw

Yup, I already have that prototyped.  Looking to fix any other bugs that are found before rolling out the next update.
Title: Re: Introducing "Folds" (a.k.a. spoilers)
Post by: SpAmRaY on Tue, 30 April 2013, 15:03:03
More
:p!

Too awesome! Thanks for taking everyone's feedback and making it a reality.  :cool:
Title: Re: Introducing "Folds" (a.k.a. spoilers)
Post by: boost on Tue, 30 April 2013, 15:34:20
nice!!!!!!!


More
(http://i120.photobucket.com/albums/o198/jdugan4859/20sslammed.jpg)
Title: Re: Introducing "Folds" (a.k.a. spoilers)
Post by: Michael on Tue, 30 April 2013, 15:46:51

I told you not to post photos of my car, bro....


:(

Quote from: boost on Tue, 30 April 2013, 15:34:20
nice!!!!!!!


More
Show Image
(http://i120.photobucket.com/albums/o198/jdugan4859/20sslammed.jpg)
Title: Re: Introducing "Folds" (a.k.a. spoilers)
Post by: SpAmRaY on Tue, 30 April 2013, 15:51:47
Quote from: Bro Caps on Tue, 30 April 2013, 15:46:51

I told you not to post photos of my car, bro....


:(

Quote from: boost on Tue, 30 April 2013, 15:34:20
nice!!!!!!!


More
Show Image
(http://i120.photobucket.com/albums/o198/jdugan4859/20sslammed.jpg)

you mean you don't drive this  :eek:

More
[attach=1]

Title: Re: Introducing "Folds" (a.k.a. spoilers)
Post by: Michael on Tue, 30 April 2013, 15:58:14
Quote from: ray4jc on Tue, 30 April 2013, 15:51:47


you mean you don't drive this  :o

More
(Attachment Link)


Only to work and back
Title: Re: Introducing "Folds" (a.k.a. spoilers)
Post by: rknize on Tue, 30 April 2013, 16:01:12
The label now toggles and if you use one in your sig it will unroll the entire signature.
Title: Re: Introducing "Folds" (a.k.a. spoilers)
Post by: SpAmRaY on Tue, 30 April 2013, 16:06:30
Quote from: rknize on Tue, 30 April 2013, 16:01:12
The label now toggles and if you use one in your sig it will unroll the entire signature.

When I click my unfold on my last post and then fold back it colapses the contents of that post and puts a scroll bar on the right..see pic for example.

Is it supposed to do this ?

Title: Re: Introducing "Folds" (a.k.a. spoilers)
Post by: rknize on Tue, 30 April 2013, 16:08:24
Nope.  BUG!

Edit: temp fix in place.  Don't know how i missed that.
Title: Re: Introducing "Folds" (a.k.a. spoilers)
Post by: rknize on Tue, 30 April 2013, 16:15:41
OK, fixed.  :o
Title: Re: Introducing "Folds" (a.k.a. spoilers)
Post by: SmallFry on Tue, 30 April 2013, 16:16:55
Also, is there a way to auto fold image tags when quoting a post? That would be quite cool.
Title: Re: Introducing "Folds" (a.k.a. spoilers)
Post by: rknize on Tue, 30 April 2013, 16:29:38
Yes, that is something that is also worth doing.
Title: Re: Introducing "Folds" (a.k.a. spoilers)
Post by: Dubsgalore on Tue, 30 April 2013, 16:35:06
More
Awesome

Title: Re: Introducing "Folds" (a.k.a. spoilers)
Post by: domoaligato on Tue, 30 April 2013, 16:37:31
BTW this doesn't work in tapatalk.
Title: Re: Introducing "Folds" (a.k.a. spoilers)
Post by: rknize on Tue, 30 April 2013, 16:48:34
Quote from: domoaligato on Tue, 30 April 2013, 16:37:31
BTW this doesn't work in tapatalk.

I noticed.  It never will work, but Tapatalk needs to strip that tag.
Title: Re: Introducing "Folds" (a.k.a. spoilers)
Post by: domoaligato on Tue, 30 April 2013, 18:39:14
Thanks for looking at this.
Title: Re: Introducing "Folds" (a.k.a. spoilers)
Post by: rknize on Wed, 01 May 2013, 02:16:09
OK, I renamed this feature simply as "more".  As I went to extend it to quoted images, the current name started to seem silly.  The old "fold" tag is still supported, but I may remove it at a later date.

Most quote images should now be hidden by default.  There are some rather tricky problems with this due to the design of the parser and the way HighSlide glues itself into it.  So for now, off site images that are wrapped with URL tags will not be hidden.  I may revisit this down the road.

This change was tricky, so let me know what bugs you come across.
Title: Re: Introducing "More" (a.k.a. spoilers)
Post by: calavera on Wed, 01 May 2013, 02:39:40
Can't it be more obvious? Instead of less and more, just have it say click to expand or something.
Title: Re: Introducing "More" (a.k.a. spoilers)
Post by: SmallFry on Wed, 01 May 2013, 09:05:56
It seems that the Folds have affected [img ] tags site wide, even when not quoted. Did they?
Title: Re: Introducing "More" (a.k.a. spoilers)
Post by: esoomenona on Wed, 01 May 2013, 09:11:08
Quote from: calavera on Wed, 01 May 2013, 02:39:40
Can't it be more obvious? Instead of less and more, just have it say click to expand or something.
Agreed. More is a bit vague, and unless you know to click something, someone might pass by it without much attention.
Title: Re: Introducing "More" (a.k.a. spoilers)
Post by: rknize on Wed, 01 May 2013, 09:38:58
Quote from: esoomenona on Wed, 01 May 2013, 09:11:08
Quote from: calavera on Wed, 01 May 2013, 02:39:40
Can't it be more obvious? Instead of less and more, just have it say click to expand or something.
Agreed. More is a bit vague, and unless you know to click something, someone might pass by it without much attention.

Any suggestions other than "click to expand"?  Something a bit more concise?
Title: Re: Introducing "More" (a.k.a. spoilers)
Post by: esoomenona on Wed, 01 May 2013, 09:40:39
I think Expand and maybe Contract are good words. Only one word.
Title: Re: Introducing "More" (a.k.a. spoilers)
Post by: rknize on Wed, 01 May 2013, 09:40:52
Quote from: SmallFry on Wed, 01 May 2013, 09:05:56
It seems that the Folds have affected [img ] tags site wide, even when not quoted. Did they?

They shouldn't.  I used the "What did you get in the mail today?" thread as a torture test and I don't see what you are seeing.  Can you point me to an example?
Title: Re: Introducing "More" (a.k.a. spoilers)
Post by: SmallFry on Wed, 01 May 2013, 09:46:11
Let me find one. I may have been delusional. Let me check for you. :)
Title: Re: Introducing "More" (a.k.a. spoilers)
Post by: CPTBadAss on Wed, 01 May 2013, 09:48:52
I really like "Spoilers" or "Fold" myself. I think I'm just used to TeamLiquid where "Spoilers" makes more sense though.
Title: Re: Introducing "More" (a.k.a. spoilers)
Post by: keymaster on Wed, 01 May 2013, 09:48:52
Great work, rknize. I'm glad you renamed it to "MORE" instead of "FOLD" :)
Title: Re: Introducing "More" (a.k.a. spoilers)
Post by: SmallFry on Wed, 01 May 2013, 09:49:48
Omit what I said, I must've been dumb or stupid. Thanks for le Folds.
Title: Re: Introducing "More" (a.k.a. spoilers)
Post by: esoomenona on Wed, 01 May 2013, 09:50:33
Quote from: CPTBadAss on Wed, 01 May 2013, 09:48:52
I really like "Spoilers" or "Fold" myself. I think I'm just used to TeamLiquid where "Spoilers" makes more sense though.
Yeah, I don't think they should be Spoilers, as we don't generally use them for that particular use, but more of a general use. Also, we have the spoilers already. They may not be the same as other sites, but they serve the same function.
Title: Re: Introducing "More" (a.k.a. spoilers)
Post by: SmallFry on Wed, 01 May 2013, 09:56:03
Also, the folding inside quotes is working wonderfully. Thanks a million. Much nicer to browse.
Title: Re: Introducing "More" (a.k.a. spoilers)
Post by: SpAmRaY on Wed, 01 May 2013, 10:01:32
so should we be using [ fold ] [ /fold ] or [ more] [ /more]
Title: Re: Introducing "More" (a.k.a. spoilers)
Post by: rknize on Wed, 01 May 2013, 10:04:12
Blogs make generous use of a "more" link to truncate long articles on their front pages.  So that's why I switched the name...it's something that most folks should be familiar with.  "Fold" is kind of obtuse and we already have spoiler tags, which do exactly that and only that: hide spoilers as a sort of redaction.
Title: Re: Introducing "More" (a.k.a. spoilers)
Post by: esoomenona on Wed, 01 May 2013, 10:07:46
I think the way a link entitled More in a blog is more intuitive than what we have here. Everyone knows what a blue underlined link does. What we have here could be misconstrued as an image with the word More on it, and possibly be overlooked. That is just my opinion. I understand it, so I'm fine. Just want to make sure everyone else is. I won't mention it anymore.

Thanks again for all the work to do this.
Title: Re: Introducing "More" (a.k.a. spoilers)
Post by: calavera on Wed, 01 May 2013, 10:27:56
I guess more/less is better. Show/hide, hidden/visible, open/close...etc would have made some good alternatives too IMO.
Title: Re: Introducing "More" (a.k.a. spoilers)
Post by: rknize on Wed, 01 May 2013, 10:37:09
Show/Hide is a contender.  How about "Show More" and "Show Less"?
Title: Re: Re: Introducing "More" (a.k.a. spoilers)
Post by: SmallFry on Wed, 01 May 2013, 10:38:16
Quote from: rknize on Wed, 01 May 2013, 10:37:09
Show/Hide is a contender.  How about "Show More" and "Show Less"?
Less words>more words IMO.
Title: Re: Introducing "More" (a.k.a. spoilers)
Post by: esoomenona on Wed, 01 May 2013, 10:40:52
I think Show/Hide works, and it is in line with the Show Images.
Title: Re: Introducing "More" (a.k.a. spoilers)
Post by: SmallFry on Wed, 01 May 2013, 10:43:38
Keep the Show Images, since then you don't expand it on accident if images are inside. :)
Title: Re: Introducing "More" (a.k.a. spoilers)
Post by: SpAmRaY on Wed, 01 May 2013, 10:48:17
Quote from: rknize on Wed, 01 May 2013, 10:37:09
Show/Hide is a contender.  How about "Show More" and "Show Less"?

Whatever is decided what code will we use or does it matter?

Don't want posts to get broken in the future.  ;D
Title: Re: Introducing "More" (a.k.a. spoilers)
Post by: The_Beast on Wed, 01 May 2013, 10:54:03
Can some kind of check box to added so that all images show all the time? Or they just are a "show image" but only when it's in quotes?
Title: Re: Introducing "More" (a.k.a. spoilers)
Post by: esoomenona on Wed, 01 May 2013, 10:55:25
Quote from: The_Beast on Wed, 01 May 2013, 10:54:03
Can some kind of check box to added so that all images show all the time? Or they just are a "show image" but only when it's in quotes?
They should only shrink down to "Show Image" when quoted. If you see them other places, it's either the doing of the poster or a bug.
Title: Re: Introducing "More" (a.k.a. spoilers)
Post by: rknize on Wed, 01 May 2013, 10:58:36
Quote from: ray4jc on Wed, 01 May 2013, 10:48:17
Quote from: rknize on Wed, 01 May 2013, 10:37:09
Show/Hide is a contender.  How about "Show More" and "Show Less"?

Whatever is decided what code will we use or does it matter?

Don't want posts to get broken in the future.  ;D

I think we are ditching the "fold" name, so stick with the "more" tag.  The post editor will use the new tag.  I also updated the OP when I switched it over.
Title: Re: Introducing "More" (a.k.a. spoilers)
Post by: SpAmRaY on Wed, 01 May 2013, 11:01:57
Quote from: rknize on Wed, 01 May 2013, 10:58:36
Quote from: ray4jc on Wed, 01 May 2013, 10:48:17
Quote from: rknize on Wed, 01 May 2013, 10:37:09
Show/Hide is a contender.  How about "Show More" and "Show Less"?

Whatever is decided what code will we use or does it matter?

Don't want posts to get broken in the future.  ;D

I think we are ditching the "fold" name, so stick with the "more" tag.  The post editor will use the new tag.  I also updated the OP when I switched it over.

thank you for getting this all worked out...I usually just type tags...and i didn't think to read the OP  :rolleyes:
Title: Re: Introducing "More" (a.k.a. spoilers)
Post by: reaper on Wed, 01 May 2013, 23:14:58
Cool stuff indeed.  Thank you russ!  :)
Title: Re: Introducing "More" (a.k.a. spoilers)
Post by: rknize on Wed, 01 May 2013, 23:33:37
OK, "url"-wrapped images that are embedded in quote blocks should now collapse as expected.  It's a bit frail thanks to HighSlide, so LMK if you see anything bizarre.
Title: Re: Introducing "More" (a.k.a. spoilers)
Post by: WhiteFireDragon on Fri, 03 May 2013, 01:20:30
I was wondering what all these more icons were. They came out of nowhere, and lot of them too. But I'm not sure "more" is the most appropriate word. More what? Money? I agree with changing it to expand.
Title: Re: Introducing "More" (a.k.a. spoilers)
Post by: rknize on Fri, 03 May 2013, 11:27:59
Noted.
Title: Re: Introducing "More" (a.k.a. spoilers)
Post by: SmallFry on Fri, 03 May 2013, 15:13:50
It seems (at least to me) that the images in quotes are reversed, as seen here. (http://geekhack.org/index.php?topic=33130.msg878366#msg878366) The text for the thing is correct, however the image displays while in quote. I'm hosting at Picasa WebAlbums which have a format of https://lh5.googleusercontent.com/-d3JtCAvcrYw/UYL_vtUYqfI/AAAAAAAAA8A/zbQ9tZoSzgQ/s912/DSCF2201.JPG if that will help you. :)
Title: Re: Introducing "More" (a.k.a. spoilers)
Post by: esoomenona on Fri, 03 May 2013, 15:14:56
Doesn't show for me.
Title: Re: Introducing "More" (a.k.a. spoilers)
Post by: rknize on Fri, 03 May 2013, 15:24:16
Please take a screenshot, because I don't see what you are referring to.
Title: Re: Introducing "More" (a.k.a. spoilers)
Post by: SmallFry on Sat, 04 May 2013, 15:20:18
(http://i.imgur.com/USjBABx.png)
Title: Re: Introducing "More" (a.k.a. spoilers)
Post by: juju___mk on Mon, 07 March 2022, 19:01:54
More
Testing!
Title: Re: Introducing "More" (a.k.a. spoilers)
Post by: arr1 on Tue, 27 December 2022, 05:54:31
More
PANTONE 11-0601 TCX: Bright White[/size][/center]