Author Topic: Introducing "More" (a.k.a. spoilers)  (Read 33834 times)

0 Members and 1 Guest are viewing this topic.

Offline rknize

  • * Administrator
  • Thread Starter
  • Posts: 1731
  • Location: Chicago
    • metaruss
Introducing "More" (a.k.a. spoilers)
« on: Tue, 30 April 2013, 14:21:57 »
Update: the tag for this it now "more" and the icon in the editor has been updated.

I've implemented a simple roll-up mechanism that works a lot like "spoilers" on vB, phpBB, and other forums.  We already have spoilers, so I called it something else...something a little more intuitive.  You should see a new button in the toolbar:



You use it like any other tag and it should be able to wrap any page content, including images and attachments:
Code: [Select]
[more]Can't see me![/more]


More
Can't see me!


An offsite image:
More


An inline, expandable attachment:
More
20398-1



Bugs:
  • Doesn't expand sigs
  • Doesn't work on quoted images
  • Doesn't work on quoted images wrapped by URLs
  • Speed up animation
  • Change "unfold"/"refold" button label to...
    • "more"/"less"
    • "show more"/"show less"
    • "expand"/"contract"
« Last Edit: Fri, 03 May 2013, 16:01:08 by rknize »
Russ

Offline CPTBadAss

  • Woke up like this
  • Posts: 14363
    • Tactile Zine
Re: Introducing "Folds" (a.k.a. spoilers)
« Reply #1 on: Tue, 30 April 2013, 14:23:58 »
This is awesome. You're the man! I've been wanting spoilers since I started coming to GH. They're very handy to have and can clean up a lot of posts. :D

Offline esoomenona

  • Gnillort?
  • Posts: 5323
Re: Introducing "Folds" (a.k.a. spoilers)
« Reply #2 on: Tue, 30 April 2013, 14:24:44 »
More
I've implemented a simple page folding mechanism that works a lot like "spoilers" on vB and other forums.  We already have spoilers, so I called it something else...something a little more intuative.  You should see a new button in the toolbar:

(Attachment Link)

You use it like any other tag and it should be able to wrap any page content, including images and attachments:
Code: [Select]
[fold]Can't see me![/fold]
More
Can't see me!


An offsite image:
More
Show Image


An inline, expandable attachment:
More
Test

edit: super awesome. They even nest inside of each other!

Offline Photekq

  • wheat flour zone
  • Posts: 4794
  • Location: North Wales, UK
  • sorry if i was ever an ******* to you
Re: Introducing "Folds" (a.k.a. spoilers)
« Reply #3 on: Tue, 30 April 2013, 14:25:04 »
Yeah, glad to see this here. It does come in useful.
https://kbdarchive.org/
github
discord: hi mum#5710

Offline ITzNybble

  • Formerly curro123083
  • Posts: 350
  • Location: Missouri
  • Nibble or Nybble either way it sounds delicious!
Re: Introducing "Folds" (a.k.a. spoilers)
« Reply #4 on: Tue, 30 April 2013, 14:26:28 »
Wonderful!
WASD V1 Custom - MX Blue
Custom Miami QFR - MX Green
Handwired Redox-Manuform - Box Pink/Box Navy
KBD67 MKII PolyCarbonate - Gateron CJ

Offline i3oilermaker

  • * Vendor
  • Posts: 2362
  • Location: Chicago
  • techkeys.us
    • TechKeys
Re: Introducing "Folds" (a.k.a. spoilers)
« Reply #5 on: Tue, 30 April 2013, 14:26:31 »
Folding at Home
More

Offline rknize

  • * Administrator
  • Thread Starter
  • Posts: 1731
  • Location: Chicago
    • metaruss
Re: Introducing "Folds" (a.k.a. spoilers)
« Reply #6 on: Tue, 30 April 2013, 14:27:25 »
LOL....LMK what bugs you find...my jQuery is pretty rusty.
Russ

Offline esoomenona

  • Gnillort?
  • Posts: 5323
Re: Introducing "Folds" (a.k.a. spoilers)
« Reply #7 on: Tue, 30 April 2013, 14:29:52 »
I tried to test it with my signature, hoping when it unfolded, it would open the whole thing, but alas, it only opened the 100px (which still doesn't scroll...).

Offline rknize

  • * Administrator
  • Thread Starter
  • Posts: 1731
  • Location: Chicago
    • metaruss
Re: Introducing "Folds" (a.k.a. spoilers)
« Reply #8 on: Tue, 30 April 2013, 14:31:16 »
Yep, I'll look at that next.
Russ

Offline hashbaz

  • Grand Ancient One
  • * Moderator Emeritus
  • Posts: 5057
  • Location: SF Bae Area
Re: Introducing "Folds" (a.k.a. spoilers)
« Reply #9 on: Tue, 30 April 2013, 14:31:52 »
You're awesome.
More

Offline Binge

  • Island of Sandy Beaches
  • * Maker
  • Posts: 3269
  • Location: Binge Haüs
  • With Gentle Time. I Feel Very Nice.
    • Hunger Work Studio
Re: Introducing "Folds" (a.k.a. spoilers)
« Reply #10 on: Tue, 30 April 2013, 14:40:28 »
this is brilliant.... Binge Approves
60% keyboards, 100% of the time.

"What the hell Jimmy?!  It was ruined before you even put it up there with your decrepit fingers."

Offline lazerpointer

  • Posts: 602
  • Location: 35°55'00.0"N 83°53'00.0"W
  • ya gotta stay phresh
Re: Introducing "Folds" (a.k.a. spoilers)
« Reply #11 on: Tue, 30 April 2013, 14:40:39 »
Should make it change to "REFOLD" once unfolded.

Just a friendly suggestion, assuming it's even possible.

Edit;
nice tool btw
i type, therefore i geekhack

Offline rknize

  • * Administrator
  • Thread Starter
  • Posts: 1731
  • Location: Chicago
    • metaruss
Re: Introducing "Folds" (a.k.a. spoilers)
« Reply #12 on: Tue, 30 April 2013, 14:49:01 »
Should make it change to "REFOLD" once unfolded.

Just a friendly suggestion, assuming it's even possible.

Edit;
nice tool btw

Yup, I already have that prototyped.  Looking to fix any other bugs that are found before rolling out the next update.
Russ

Offline SpAmRaY

  • NOT a Moderator
  • * Certified Spammer
  • Posts: 14667
  • Location: ¯\(°_o)/¯
  • because reasons.......
Re: Introducing "Folds" (a.k.a. spoilers)
« Reply #13 on: Tue, 30 April 2013, 15:03:03 »
More
:p!

Too awesome! Thanks for taking everyone's feedback and making it a reality.  :cool:

Offline boost

  • BOSTMOBILE
  • * Elevated Elder
  • Posts: 3300
  • NY Giants!!!
Re: Introducing "Folds" (a.k.a. spoilers)
« Reply #14 on: Tue, 30 April 2013, 15:34:20 »
nice!!!!!!!


More
"Aerodynamics are for people who can't build engines."

-Enzo Ferrari

Offline Michael

  • Formerly Bro Caps
  • * Maker
  • Posts: 4632
  • REEEeeeeEEEEEEEEeeeeeeeeeeeEEEEEEEEEEEEEEEeeeee
Re: Introducing "Folds" (a.k.a. spoilers)
« Reply #15 on: Tue, 30 April 2013, 15:46:51 »

I told you not to post photos of my car, bro....


:(

nice!!!!!!!


More
Show Image

Offline SpAmRaY

  • NOT a Moderator
  • * Certified Spammer
  • Posts: 14667
  • Location: ¯\(°_o)/¯
  • because reasons.......
Re: Introducing "Folds" (a.k.a. spoilers)
« Reply #16 on: Tue, 30 April 2013, 15:51:47 »

I told you not to post photos of my car, bro....


:(

nice!!!!!!!


More
Show Image

you mean you don't drive this  :eek:

More
20429-0


Offline Michael

  • Formerly Bro Caps
  • * Maker
  • Posts: 4632
  • REEEeeeeEEEEEEEEeeeeeeeeeeeEEEEEEEEEEEEEEEeeeee
Re: Introducing "Folds" (a.k.a. spoilers)
« Reply #17 on: Tue, 30 April 2013, 15:58:14 »


you mean you don't drive this  :o

More


Only to work and back

Offline rknize

  • * Administrator
  • Thread Starter
  • Posts: 1731
  • Location: Chicago
    • metaruss
Re: Introducing "Folds" (a.k.a. spoilers)
« Reply #18 on: Tue, 30 April 2013, 16:01:12 »
The label now toggles and if you use one in your sig it will unroll the entire signature.
Russ

Offline SpAmRaY

  • NOT a Moderator
  • * Certified Spammer
  • Posts: 14667
  • Location: ¯\(°_o)/¯
  • because reasons.......
Re: Introducing "Folds" (a.k.a. spoilers)
« Reply #19 on: Tue, 30 April 2013, 16:06:30 »
The label now toggles and if you use one in your sig it will unroll the entire signature.

When I click my unfold on my last post and then fold back it colapses the contents of that post and puts a scroll bar on the right..see pic for example.

Is it supposed to do this ?


Offline rknize

  • * Administrator
  • Thread Starter
  • Posts: 1731
  • Location: Chicago
    • metaruss
Re: Introducing "Folds" (a.k.a. spoilers)
« Reply #20 on: Tue, 30 April 2013, 16:08:24 »
Nope.  BUG!

Edit: temp fix in place.  Don't know how i missed that.
Russ

Offline rknize

  • * Administrator
  • Thread Starter
  • Posts: 1731
  • Location: Chicago
    • metaruss
Re: Introducing "Folds" (a.k.a. spoilers)
« Reply #21 on: Tue, 30 April 2013, 16:15:41 »
OK, fixed.  :o
Russ

Offline SmallFry

  • ** Moderator Emeritus
  • Posts: 3887
  • Location: Wisconsin, USA
  • Leaving 6/15; returning 6/22 or so.
Re: Introducing "Folds" (a.k.a. spoilers)
« Reply #22 on: Tue, 30 April 2013, 16:16:55 »
Also, is there a way to auto fold image tags when quoting a post? That would be quite cool.

Offline rknize

  • * Administrator
  • Thread Starter
  • Posts: 1731
  • Location: Chicago
    • metaruss
Re: Introducing "Folds" (a.k.a. spoilers)
« Reply #23 on: Tue, 30 April 2013, 16:29:38 »
Yes, that is something that is also worth doing.
Russ

Offline Dubsgalore

  • Banned
  • Posts: 2849
  • Location: 75% You have received a warning for attempting to circumvent the classifieds rules
    • Dubs - Sneakers, Keyboards, and Life
Re: Introducing "Folds" (a.k.a. spoilers)
« Reply #24 on: Tue, 30 April 2013, 16:35:06 »
More
Awesome


Offline domoaligato

  • * Exquisite Elder
  • Posts: 1672
  • Location: USA
  • All your base are belong to us!
    • All your base are belong to us!
Re: Introducing "Folds" (a.k.a. spoilers)
« Reply #25 on: Tue, 30 April 2013, 16:37:31 »
BTW this doesn't work in tapatalk.

Offline rknize

  • * Administrator
  • Thread Starter
  • Posts: 1731
  • Location: Chicago
    • metaruss
Re: Introducing "Folds" (a.k.a. spoilers)
« Reply #26 on: Tue, 30 April 2013, 16:48:34 »
BTW this doesn't work in tapatalk.

I noticed.  It never will work, but Tapatalk needs to strip that tag.
Russ

Offline domoaligato

  • * Exquisite Elder
  • Posts: 1672
  • Location: USA
  • All your base are belong to us!
    • All your base are belong to us!
Re: Introducing "Folds" (a.k.a. spoilers)
« Reply #27 on: Tue, 30 April 2013, 18:39:14 »
Thanks for looking at this.

Offline rknize

  • * Administrator
  • Thread Starter
  • Posts: 1731
  • Location: Chicago
    • metaruss
Re: Introducing "Folds" (a.k.a. spoilers)
« Reply #28 on: Wed, 01 May 2013, 02:16:09 »
OK, I renamed this feature simply as "more".  As I went to extend it to quoted images, the current name started to seem silly.  The old "fold" tag is still supported, but I may remove it at a later date.

Most quote images should now be hidden by default.  There are some rather tricky problems with this due to the design of the parser and the way HighSlide glues itself into it.  So for now, off site images that are wrapped with URL tags will not be hidden.  I may revisit this down the road.

This change was tricky, so let me know what bugs you come across.
Russ

Offline calavera

  • Posts: 1713
  • Location: South Korea
Re: Introducing "More" (a.k.a. spoilers)
« Reply #29 on: Wed, 01 May 2013, 02:39:40 »
Can't it be more obvious? Instead of less and more, just have it say click to expand or something.

Offline SmallFry

  • ** Moderator Emeritus
  • Posts: 3887
  • Location: Wisconsin, USA
  • Leaving 6/15; returning 6/22 or so.
Re: Introducing "More" (a.k.a. spoilers)
« Reply #30 on: Wed, 01 May 2013, 09:05:56 »
It seems that the Folds have affected [img ] tags site wide, even when not quoted. Did they?

Offline esoomenona

  • Gnillort?
  • Posts: 5323
Re: Introducing "More" (a.k.a. spoilers)
« Reply #31 on: Wed, 01 May 2013, 09:11:08 »
Can't it be more obvious? Instead of less and more, just have it say click to expand or something.
Agreed. More is a bit vague, and unless you know to click something, someone might pass by it without much attention.

Offline rknize

  • * Administrator
  • Thread Starter
  • Posts: 1731
  • Location: Chicago
    • metaruss
Re: Introducing "More" (a.k.a. spoilers)
« Reply #32 on: Wed, 01 May 2013, 09:38:58 »
Can't it be more obvious? Instead of less and more, just have it say click to expand or something.
Agreed. More is a bit vague, and unless you know to click something, someone might pass by it without much attention.

Any suggestions other than "click to expand"?  Something a bit more concise?
Russ

Offline esoomenona

  • Gnillort?
  • Posts: 5323
Re: Introducing "More" (a.k.a. spoilers)
« Reply #33 on: Wed, 01 May 2013, 09:40:39 »
I think Expand and maybe Contract are good words. Only one word.

Offline rknize

  • * Administrator
  • Thread Starter
  • Posts: 1731
  • Location: Chicago
    • metaruss
Re: Introducing "More" (a.k.a. spoilers)
« Reply #34 on: Wed, 01 May 2013, 09:40:52 »
It seems that the Folds have affected [img ] tags site wide, even when not quoted. Did they?

They shouldn't.  I used the "What did you get in the mail today?" thread as a torture test and I don't see what you are seeing.  Can you point me to an example?
Russ

Offline SmallFry

  • ** Moderator Emeritus
  • Posts: 3887
  • Location: Wisconsin, USA
  • Leaving 6/15; returning 6/22 or so.
Re: Introducing "More" (a.k.a. spoilers)
« Reply #35 on: Wed, 01 May 2013, 09:46:11 »
Let me find one. I may have been delusional. Let me check for you. :)

Offline CPTBadAss

  • Woke up like this
  • Posts: 14363
    • Tactile Zine
Re: Introducing "More" (a.k.a. spoilers)
« Reply #36 on: Wed, 01 May 2013, 09:48:52 »
I really like "Spoilers" or "Fold" myself. I think I'm just used to TeamLiquid where "Spoilers" makes more sense though.

Offline keymaster

  • Topre Revolution Theorist
  • Posts: 1148
Re: Introducing "More" (a.k.a. spoilers)
« Reply #37 on: Wed, 01 May 2013, 09:48:52 »
Great work, rknize. I'm glad you renamed it to "MORE" instead of "FOLD" :)

Offline SmallFry

  • ** Moderator Emeritus
  • Posts: 3887
  • Location: Wisconsin, USA
  • Leaving 6/15; returning 6/22 or so.
Re: Introducing "More" (a.k.a. spoilers)
« Reply #38 on: Wed, 01 May 2013, 09:49:48 »
Omit what I said, I must've been dumb or stupid. Thanks for le Folds.

Offline esoomenona

  • Gnillort?
  • Posts: 5323
Re: Introducing "More" (a.k.a. spoilers)
« Reply #39 on: Wed, 01 May 2013, 09:50:33 »
I really like "Spoilers" or "Fold" myself. I think I'm just used to TeamLiquid where "Spoilers" makes more sense though.
Yeah, I don't think they should be Spoilers, as we don't generally use them for that particular use, but more of a general use. Also, we have the spoilers already. They may not be the same as other sites, but they serve the same function.

Offline SmallFry

  • ** Moderator Emeritus
  • Posts: 3887
  • Location: Wisconsin, USA
  • Leaving 6/15; returning 6/22 or so.
Re: Introducing "More" (a.k.a. spoilers)
« Reply #40 on: Wed, 01 May 2013, 09:56:03 »
Also, the folding inside quotes is working wonderfully. Thanks a million. Much nicer to browse.

Offline SpAmRaY

  • NOT a Moderator
  • * Certified Spammer
  • Posts: 14667
  • Location: ¯\(°_o)/¯
  • because reasons.......
Re: Introducing "More" (a.k.a. spoilers)
« Reply #41 on: Wed, 01 May 2013, 10:01:32 »
so should we be using [ fold ] [ /fold ] or [ more] [ /more]

Offline rknize

  • * Administrator
  • Thread Starter
  • Posts: 1731
  • Location: Chicago
    • metaruss
Re: Introducing "More" (a.k.a. spoilers)
« Reply #42 on: Wed, 01 May 2013, 10:04:12 »
Blogs make generous use of a "more" link to truncate long articles on their front pages.  So that's why I switched the name...it's something that most folks should be familiar with.  "Fold" is kind of obtuse and we already have spoiler tags, which do exactly that and only that: hide spoilers as a sort of redaction.
Russ

Offline esoomenona

  • Gnillort?
  • Posts: 5323
Re: Introducing "More" (a.k.a. spoilers)
« Reply #43 on: Wed, 01 May 2013, 10:07:46 »
I think the way a link entitled More in a blog is more intuitive than what we have here. Everyone knows what a blue underlined link does. What we have here could be misconstrued as an image with the word More on it, and possibly be overlooked. That is just my opinion. I understand it, so I'm fine. Just want to make sure everyone else is. I won't mention it anymore.

Thanks again for all the work to do this.

Offline calavera

  • Posts: 1713
  • Location: South Korea
Re: Introducing "More" (a.k.a. spoilers)
« Reply #44 on: Wed, 01 May 2013, 10:27:56 »
I guess more/less is better. Show/hide, hidden/visible, open/close...etc would have made some good alternatives too IMO.

Offline rknize

  • * Administrator
  • Thread Starter
  • Posts: 1731
  • Location: Chicago
    • metaruss
Re: Introducing "More" (a.k.a. spoilers)
« Reply #45 on: Wed, 01 May 2013, 10:37:09 »
Show/Hide is a contender.  How about "Show More" and "Show Less"?
Russ

Offline SmallFry

  • ** Moderator Emeritus
  • Posts: 3887
  • Location: Wisconsin, USA
  • Leaving 6/15; returning 6/22 or so.
Re: Re: Introducing "More" (a.k.a. spoilers)
« Reply #46 on: Wed, 01 May 2013, 10:38:16 »
Show/Hide is a contender.  How about "Show More" and "Show Less"?
Less words>more words IMO.

Offline esoomenona

  • Gnillort?
  • Posts: 5323
Re: Introducing "More" (a.k.a. spoilers)
« Reply #47 on: Wed, 01 May 2013, 10:40:52 »
I think Show/Hide works, and it is in line with the Show Images.

Offline SmallFry

  • ** Moderator Emeritus
  • Posts: 3887
  • Location: Wisconsin, USA
  • Leaving 6/15; returning 6/22 or so.
Re: Introducing "More" (a.k.a. spoilers)
« Reply #48 on: Wed, 01 May 2013, 10:43:38 »
Keep the Show Images, since then you don't expand it on accident if images are inside. :)

Offline SpAmRaY

  • NOT a Moderator
  • * Certified Spammer
  • Posts: 14667
  • Location: ¯\(°_o)/¯
  • because reasons.......
Re: Introducing "More" (a.k.a. spoilers)
« Reply #49 on: Wed, 01 May 2013, 10:48:17 »
Show/Hide is a contender.  How about "Show More" and "Show Less"?

Whatever is decided what code will we use or does it matter?

Don't want posts to get broken in the future.  ;D