GMK Midnight Rainbow did not donate any proceeds afaik. But it was also a set that was inspired by Pride, but not necessarily meant to be specifically explicitly Pride themed or intended to raise awareness. It was just a rainbow set. Proving that you can make a rainbow set and nobody will complain. (And not everything rainbow is automatically queer.)
It's when you make a set that's supposed to support a certain group of people that members of that group might come out and say "Here's how you could support us better" which I think is... good? And characterising marginalised people having opinions about things that relate to their marginalisation and the fight against it as angry, mean, and ungrateful is not great if you belong to the same group, and really bad if you don't.
Which isn't to say you can't disagree with the position of all the queer people speaking here (providing you're queer yourself, if you're an ally this isn't an issue that affects you and your voice can be better used elsewhere). The argument is that queer people are marginalised by non-queer people, denied opportunities, more likely to suffer from mental health issues, be homeless, driven to substance abuse, be in financial trouble, or just be killed. Pride is a symbol of defiance in face of all of that. It's not our orientations or gender identities being inherently something to be proud of, it's being proud of them as an act of rebellion against the systems that tells us to be ashamed. And non-queer people looking at this, taking our stories, telling them in their voices and profiting off of them is less helpful than some might think, and this includes selling us stuff with rainbows on it so we can display solidarity to each other while non-queer people take the money.
The counterargument to all of this is - if you're gonna buy a GMK set someone's gonna take that money anyway and at least this one has a pretty rainbow on it. What some people call rainbow capitalism is no different than regular capitalism and getting angry about it as a special kind of issue is kinda silly. We should be glad it's deemed profitable to market to us, that wasn't the case not so long ago.
And I personally agree with the second position more than the first one, I'd rather Pepsi have rainbows on it then to pretend I don't deserve to exist. But if you want to produce something like a keycap set with the explicit intention of supporting the queer/LBGTQIA+ community, might just as well try to do so in the most effective way possible.
Either way I think we all agree that the set looks much better now (again, I really like the current version) and that leaving out the original novelties was a good call. I think OP should be compensated for their labour, but I also think that donating to charity would not only help us more than just selling us a thing, but would also mean way more as a gesture of inclusivity and could help drive awareness of actual queer issues (which ones depends on the charity chosen) much stronger than just a rainbow set. We've manufactured pieces of plastic to help fight the climate change, we've raised money for a breast cancer charity, for Elephant preservation, this community is no stranger doing stuff like this and it would be awesome if we could see this set the ranks of other cool charitable sets.